Skip to content

Support tool calling in native ollama provider#9696

Merged
mrubens merged 3 commits intomainfrom
ollama_ntc
Dec 1, 2025
Merged

Support tool calling in native ollama provider#9696
mrubens merged 3 commits intomainfrom
ollama_ntc

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Nov 30, 2025 •
edited by ellipsis-dev bot
Loading

(And remove the deprecated ollama provider)

Important

Enhance NativeOllamaHandler with tool calling support and remove deprecated OllamaHandler.

  • Behavior:
    • Adds support for native tool calling in NativeOllamaHandler in native-ollama.ts.
    • Removes deprecated OllamaHandler and its tests (ollama.ts, ollama.spec.ts, ollama-timeout.spec.ts).
  • Tests:
    • Updates native-ollama.spec.ts to test tool calling functionality, including cases where tools are included or excluded based on model support and protocol.
    • Updates ollama.test.ts to include supportsNativeTools in model parsing.
  • Misc:
    • Removes OllamaHandler export from index.ts.
    • Adds supportsNativeTools to ollamaDefaultModelInfo in ollama.ts.

This description was created by Ellipsis for dbe5411. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners November 30, 2025 04:58
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Nov 30, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 30, 2025 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found with the new changes.

The latest commit correctly updates test expectations to include supportsNativeTools: true, which aligns with the ollamaDefaultModelInfo that was updated in the previous commits.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 30, 2025
@mrubens
Copy link
Collaborator Author

mrubens commented Nov 30, 2025

@roomote fix the failing test please

@roomote
Copy link
Contributor

roomote bot commented Nov 30, 2025 •
edited
Loading

Fixaroo Clock   See task on Roo Cloud

Fixed the failing test by adding supportsNativeTools: true to the expected results in ollama.test.ts. All local checks passed.

View commit | Revert commit

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2025
@mrubens mrubens merged commit be76594 into main Dec 1, 2025
12 of 13 checks passed
@mrubens mrubens deleted the ollama_ntc branch December 1, 2025 20:28
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Dec 1, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-lxs daniel-lxs daniel-lxs approved these changes

@roomote roomote[bot] roomote[bot] approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

No open projects
Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrubens @daniel-lxs @hannesrudolph @roomote